1) Moon charm drops from Werewolves, you are thinking of the Moon Stone.
Same difference, both are required for the Celestial Stone, but yes, I meant Moon Stone.
2) ONLY 2 broken hero swords? You do know that they are a 1/4 chance to drop from a MOTHRON
Mothrons are uncommon (never mind, rare) mini-bosses in Solar Eclipses. They only appear after Plantera. They have high health (and exponentially higher in Expert), not to mention the 5K MOTH SWARMS THAT THEY SPAWN!!! This makes Mothrons 1) super hard to find 2) very hard to kill if you find one and 3) hard to get the sword if you kill one.
Really? Every single Solar Eclipse I've ever had Post-Plantera in 1.3.0.8, I've had to fight at least 3, sometimes up to 5-6 Mothrons per. Given the fact that you can go to the Lihzarhd Temple and get enough Solar Tablets to spawn 20+ Eclipses within an hour, I'd say that the Mothrons are really not a problem.
I say the IF is a bit easier to get, as you only have to do one part for it, instead of using your Hallowed bars instead of making armor and stuff.
If you're wanting a sword, then you're melee. Why on Terra would you ever make Hallowed Armor when Titanium Armor exists? Even if you have Adamantite, that's plenty good enough to get you to Turtle Armor; the Hallowed Gear doesn't give you that much of any boost over Adamantite. The difference is negligible, and you'd have to kill a couple bosses to get enough to make the full suit anyways, right?
The Night's Edge is hard to get, as you have to go around to four different places to make it, inevitably dying multiple times.
Wha...?
1). Kill EoC. That's.. hard?
2). Go to the Dungeon and open chests... you're gonna do that anyways, right?
3). Get 12 Stingers and some spores (dunno about you, but when I'm looking for an Anklet of the Wind, I have far more than I ever need to make the BoG)
4). Gathering Hellstone... if you're a melee, you're either grinding for a Cascade drop or you're mining up Hellstone for your Hellstone Armor anyways (unless you're gonna skip it with Crimson Armor, but still. You need at the very least a pickaxe unless you're gonna fish for hours).
5). Find a demon altar to put them together.... uh, not hard?
Also, you mean best melee in pre-hardmode?
I thought I was being obvious when I said that the NE was the best melee in normal/easymode. Whatever the terminology you wanna use. It is the single best weapon damage-wise; it out-damages the Cascade hit-for-hit, but might do slightly less DPS on mobs with low defense due to the Cascade's ability to hit several times in quick succession.
Terra Blade is Hardmode, it OBVIOUSLY surpasses NE. Then, you need to face the Mothrons, which are giant chainsaw killing machines (under exaggeration) that will tear you apart more quickly than you can say, "I probably should have taken the Influx Waver instead."
NE + Some waste of Hallowed + Mothrons + Killing one > Finding probe + Having chances in your favor.
They're still kind of cool weapons, just one is easier than the other and they have different uses!
I dunno about you, but I found Mothrons to be rather easy because the only things Mothrons DO is fly at you and release little bugs (after taking a long time to lay the eggs). When it flies off to land on the ground, run after it, use your weapons on it and you'll kill the eggs and hit Mothron at the same time. While laying the eggs, the Mothron is defenseless unless you actually walk up to it and touch it. When he's in the air, wait for him to charge and..... jump. He's basically Queen Bee without the projectiles and the bees. All you need is a few wood platforms in the air, and perhaps a rope to hang on to stay above the mosh pit.
If you want, I'll post a video of me killing several with naught but an Amarok and Adamantite Armor. They really aren't hard at all.