Honestly, I'd choose Genshin Impact, since it's pretty much the only game I play nowadays. The beautiful sceneries and the awesome soundtracks outweigh any negative sides the game has for me, and since it's continuously updated for more content, it's going to stay there for years. I don't even think you could bribe me to let go of it.
Terraria (& tModLoader, but they're excluded here) and Minecraft come close, though. Sandboxes with endless playtime can be replayed over and over without anyone ever getting bored.