Celestial Magnet is a class-specific combat accessory that draws away from the utility of the other two
While I agree that celestial magnet is most beneficial for magic users, why not tack it in to this item that is intended to be a combination of all the attraction accessories? Even non-magic users will still get benefit from this accessory since it combines the item that attracts items with the item that attracts gold. I think this would be an appreciated addition for many types of players.
How though does it "draw away from the utility of the other two"? In what way does including the celestial magnet effect hinder the other two?
Treasure Magnet doesn't need more upgrades, it's fine as is; same goes for Gold Ring.
I disagree. Currently the treasure magnet is ONLY used in the architect gizmo pack, which relies on waiting around for travelling merchant rng. Adding this suggested accessory would provide players with another option.
As for the ring, in my opinion coins feel extremely plentiful. Beyond early game, I dont think ive ever noticed any impact from the 20% discount provided by the gold ring's upgrade, or been glad I have that effect. Same goes for the "enemies drop coins when hit" effect. But I do however love the coin magnet effect and often use the item solely for that. Providing another use for the gold ring would provide players with a choice.
And player agency is a good thing. For example, when you get your beetle husks, you have to decide which set to craft. When you get any hardmode ore you have to decide which headgear to craft. When you get any crafting material you have to decide what you wish to invest those resources into. Why can the same choice not go for accessories?
Again, adding more branches off niche ones meant for a single purpose goes against what they were created for.
I disagree that these accessories are "meant for a single purpose" or were "created for" only the one use they may or may not have currently. Why do the hellfire treads exist since the spectre boots were clearly meant for the single purpose of ultimately being combined into the terraspark boots? Why does the stardust cell staff exist when everyone just goes with the stardust dragon?
Choice is okay.