PC Town npc for my mod

I have tried everything. It just does not work. Can someone pls help? Here is the code.

using System;
using System.Collections.Generic;
using Microsoft.Xna.Framework;
using Microsoft.Xna.Framework.Graphics;
using Terraria.ID;
using Terraria;
using Terraria.ModLoader;

namespace DogeMod.NPCs
{
public class gooddoge : ModNPC
{
public override bool Autoload(ref string name, ref string texture, ref string altTextures)
{
name = "gooddoge";
return mod.Properties.Autoload;
}
public override void SetDefaults()
{
npc.name = "The Good Doge"; //the name displayed when hovering over the npc ingame.
npc.townNPC = true; //This defines if the npc is a town Npc or not
npc.friendly = true; //this defines if the npc can hurt you or not()
npc.width = 18; //the npc sprite width
npc.height = 46; //the npc sprite height
npc.aiStyle = 7; //this is the npc ai style, 7 is Pasive Ai
npc.defense = 25; //the npc defense
npc.lifeMax = 250;// the npc life
npc.HitSound = SoundID.NPCHit1; //the npc sound when is hit
npc.DeathSound = SoundID.NPCDeath1; //the npc sound when he dies
npc.knockBackResist = 0.5f; //the npc knockback resistance
Main.npcFrameCount[npc.type] = 25; //this defines how many frames the npc sprite sheet has
NPCID.Sets.ExtraFramesCount[npc.type] = 9;
NPCID.Sets.AttackFrameCount[npc.type] = 4;
NPCID.Sets.DangerDetectRange[npc.type] = 150; //this defines the npc danger detect range
NPCID.Sets.AttackType[npc.type] = 3; //this is the attack type, 0 (throwing), 1 (shooting), or 2 (magic). 3 (melee)
NPCID.Sets.AttackTime[npc.type] = 30; //this defines the npc attack speed
NPCID.Sets.AttackAverageChance[npc.type] = 10;//this defines the npc atack chance
NPCID.Sets.HatOffsetY[npc.type] = 4; //this defines the party hat position
animationType = NPCID.Guide; //this copy the guide animation
}
public override bool CanTownNPCSpawn(int numTownNPCs, int money) //Whether or not the conditions have been met for this town NPC to be able to move into town.
{
if (NPC.downedBoss113) //so after the Wall is killed
{
return true;
}
return false;
}
public override bool CheckConditions(int left, int right, int top, int bottom) //Allows you to define special conditions required for this town NPC's house
{
return true; //so when a house is available the npc will spawn
}
public override string TownNPCName() //Allows you to give this town NPC any name when it spawns
{
switch (WorldGen.genRand.Next(6))
{
case 0:
return "Wyatt";
case 1:
return "Jack";
case 2:
return "Michael";
case 3:
return "Shiba";
case 4:
return "Green Doge";
case 5:
return "Blue Wow";
default:
return "Mr. Inu";
}
}

public override void SetChatButtons(ref string button, ref string button2) //Allows you to set the text for the buttons that appear on this town NPC's chat window.
{
button = "Shop"; //this defines the buy button name
}
public override void OnChatButtonClicked(bool firstButton, ref bool openShop) //Allows you to make something happen whenever a button is clicked on this town NPC's chat window. The firstButton parameter tells whether the first button or second button (button and button2 from SetChatButtons) was clicked. Set the shop parameter to true to open this NPC's shop.
{

if (firstButton)
{
openShop = true; //so when you click on buy button opens the shop
}
}

public override void SetupShop(Chest shop, ref int nextSlot) //Allows you to add items to this town NPC's shop. Add an item by setting the defaults of shop.item[nextSlot] then incrementing nextSlot.
{
if (NPC.downedSlimeKing) //this make so when the king slime is killed the town npc will sell this
{
shop.item[nextSlot].SetDefaults(ItemID.ThornHook); //an example of how to add a vanilla terraria item
nextSlot++;
shop.item[nextSlot].SetDefaults(ItemID.WormholePotion);
nextSlot++;
shop.item[nextSlot].SetDefaults(ItemID.ImpStaff);
nextSlot++;
}
if (NPC.downedBoss127) //this make so when SkeletronPrime is killed the town npc will sell this
{
shop.item[nextSlot].SetDefaults(ItemID.SolarCultistHood);
nextSlot++;
shop.item[nextSlot].SetDefaults(ItemID.SolarCultistRobe);
nextSlot++;
}
shop.item[nextSlot].SetDefaults(ItemID.IronskinPotion);
nextSlot++;
shop.item[nextSlot].SetDefaults(mod.ItemType("Doge")); //this is an example of how to add a modded item
nextSlot++;

}

public override string GetChat() //Allows you to give this town NPC a chat message when a player talks to it.
{
int wizardNPC = NPC.FindFirstNPC(NPCID.Wizard); //this make so when this npc is close to Wizard
if (wizardNPC >= 0 && Main.rand.Next(4) == 0) //has 1 in 3 chance to show this message
{
return "Yes " + Main.npc[wizardNPC].displayName + " is a wizard.";
}
int guideNPC = NPC.FindFirstNPC(NPCID.Guide); //this make so when this npc is close to the Guide
if (guideNPC >= 0 && Main.rand.Next(4) == 0) //has 1 in 3 chance to show this message
{
return "Sure you can ask " + Main.npc[guideNPC].displayName + " how to make Ironskin potion or you can buy it from me..hehehe.";
}
switch (Main.rand.Next(4)) //this are the messages when you talk to the npc
{
case 0:
return "Doge does not die";
case 1:
return "Got that wall thing yet?";
case 2:
return "I like living here, it's very wow";
case 3:
return "Want to buy something?";
default:
return "Very wow";

}
}
public override void TownNPCAttackStrength(ref int damage, ref float knockback)// Allows you to determine the damage and knockback of this town NPC attack
{
damage = 40; //npc damage
knockback = 2f; //npc knockback
}

public override void TownNPCAttackCooldown(ref int cooldown, ref int randExtraCooldown) //Allows you to determine the cooldown between each of this town NPC's attack. The cooldown will be a number greater than or equal to the first parameter, and less then the sum of the two parameters.
{
cooldown = 5;
randExtraCooldown = 10;
}
//------------------------------------This is an example of how to make the npc use a sward attack-------------------------------
public override void DrawTownAttackSwing(ref Texture2D item, ref int itemSize, ref float scale, ref Vector2 offset)//Allows you to customize how this town NPC's weapon is drawn when this NPC is swinging it (this NPC must have an attack type of 3). Item is the Texture2D instance of the item to be drawn (use Main.itemTexture[id of item]), itemSize is the width and height of the item's hitbox
{
scale = 1f;
item = Main.itemTexture[mod.ItemType("Doge")]; //this defines the item that this npc will use
itemSize = 56;
}

public override void TownNPCAttackSwing(ref int itemWidth, ref int itemHeight) // Allows you to determine the width and height of the item this town NPC swings when it attacks, which controls the range of this NPC's swung weapon.
{
itemWidth = 56;
itemHeight = 56;
}

//----------------------------------This is an example of how to make the npc use a gun and a projectile ----------------------------------
/*public override void DrawTownAttackGun(ref float scale, ref int item, ref int closeness) //Allows you to customize how this town NPC's weapon is drawn when this NPC is shooting (this NPC must have an attack type of 1). Scale is a multiplier for the item's drawing size, item is the ID of the item to be drawn, and closeness is how close the item should be drawn to the NPC.
{
scale = 1f;
item = mod.ItemType("GunName");
closeness = 20;
}
public override void TownNPCAttackProj(ref int projType, ref int attackDelay)//Allows you to determine the projectile type of this town NPC's attack, and how long it takes for the projectile to actually appear
{
projType = ProjectileID.CrystalBullet;
attackDelay = 1;
}

public override void TownNPCAttackProjSpeed(ref float multiplier, ref float gravityCorrection, ref float randomOffset)//Allows you to determine the speed at which this town NPC throws a projectile when it attacks. Multiplier is the speed of the projectile, gravityCorrection is how much extra the projectile gets thrown upwards, and randomOffset allows you to randomize the projectile's velocity in a square centered around the original velocity
{
multiplier = 7f;
// randomOffset = 4f;

} */

}
}
 
T-modloader says that this line of code is wrong. This part of the mod does not work, its my first mod.

public override bool Autoload(ref string name, ref string texture, ref string altTextures)

(Its near the top of the full script)
 
T-modloader says that this line of code is wrong. This part of the mod does not work, its my first mod.

public override bool Autoload(ref string name, ref string texture, ref string altTextures)

(Its near the top of the full script)

I wish I could help as I’m not home. But remove that line and see if that helps.
 
Ok, sorry for wasting your time. I got a new error that says "Error CS1519" Here is the new code.

using System;
using System.Collections.Generic;
using Microsoft.Xna.Framework;
using Microsoft.Xna.Framework.Graphics;
using Terraria.ID;
using Terraria;
using Terraria.ModLoader;

namespace DogeMod.NPCs
{
public class gooddoge : ModNPC
{


name = "gooddoge";
return mod.Properties.Autoload;
}
public override void SetDefaults()
{
npc.name = "The Good Doge"; //the name displayed when hovering over the npc ingame.
npc.townNPC = true; //This defines if the npc is a town Npc or not
npc.friendly = true; //this defines if the npc can hurt you or not()
npc.width = 18; //the npc sprite width
npc.height = 46; //the npc sprite height
npc.aiStyle = 7; //this is the npc ai style, 7 is Pasive Ai
npc.defense = 25; //the npc defense
npc.lifeMax = 250;// the npc life
npc.HitSound = SoundID.NPCHit1; //the npc sound when is hit
npc.DeathSound = SoundID.NPCDeath1; //the npc sound when he dies
npc.knockBackResist = 0.5f; //the npc knockback resistance
Main.npcFrameCount[npc.type] = 25; //this defines how many frames the npc sprite sheet has
NPCID.Sets.ExtraFramesCount[npc.type] = 9;
NPCID.Sets.AttackFrameCount[npc.type] = 4;
NPCID.Sets.DangerDetectRange[npc.type] = 150; //this defines the npc danger detect range
NPCID.Sets.AttackType[npc.type] = 3; //this is the attack type, 0 (throwing), 1 (shooting), or 2 (magic). 3 (melee)
NPCID.Sets.AttackTime[npc.type] = 30; //this defines the npc attack speed
NPCID.Sets.AttackAverageChance[npc.type] = 10;//this defines the npc atack chance
NPCID.Sets.HatOffsetY[npc.type] = 4; //this defines the party hat position
animationType = NPCID.Guide; //this copy the guide animation
}
public override bool CanTownNPCSpawn(int numTownNPCs, int money) //Whether or not the conditions have been met for this town NPC to be able to move into town.
{
if (NPC.downedBoss113) //so after the Wall is killed
{
return true;
}
return false;
}
public override bool CheckConditions(int left, int right, int top, int bottom) //Allows you to define special conditions required for this town NPC's house
{
return true; //so when a house is available the npc will spawn
}
public override string TownNPCName() //Allows you to give this town NPC any name when it spawns
{
switch (WorldGen.genRand.Next(6))
{
case 0:
return "Wyatt";
case 1:
return "Jack";
case 2:
return "Michael";
case 3:
return "Shiba";
case 4:
return "Green Doge";
case 5:
return "Blue Wow";
default:
return "Mr. Inu";
}
}

public override void SetChatButtons(ref string button, ref string button2) //Allows you to set the text for the buttons that appear on this town NPC's chat window.
{
button = "Shop"; //this defines the buy button name
}
public override void OnChatButtonClicked(bool firstButton, ref bool openShop) //Allows you to make something happen whenever a button is clicked on this town NPC's chat window. The firstButton parameter tells whether the first button or second button (button and button2 from SetChatButtons) was clicked. Set the shop parameter to true to open this NPC's shop.
{

if (firstButton)
{
openShop = true; //so when you click on buy button opens the shop
}
}

public override void SetupShop(Chest shop, ref int nextSlot) //Allows you to add items to this town NPC's shop. Add an item by setting the defaults of shop.item[nextSlot] then incrementing nextSlot.
{
if (NPC.downedSlimeKing) //this make so when the king slime is killed the town npc will sell this
{
shop.item[nextSlot].SetDefaults(ItemID.ThornHook); //an example of how to add a vanilla terraria item
nextSlot++;
shop.item[nextSlot].SetDefaults(ItemID.WormholePotion);
nextSlot++;
shop.item[nextSlot].SetDefaults(ItemID.ImpStaff);
nextSlot++;
}
if (NPC.downedBoss127) //this make so when SkeletronPrime is killed the town npc will sell this
{
shop.item[nextSlot].SetDefaults(ItemID.SolarCultistHood);
nextSlot++;
shop.item[nextSlot].SetDefaults(ItemID.SolarCultistRobe);
nextSlot++;
}
shop.item[nextSlot].SetDefaults(ItemID.IronskinPotion);
nextSlot++;
shop.item[nextSlot].SetDefaults(mod.ItemType("Doge")); //this is an example of how to add a modded item
nextSlot++;

}

public override string GetChat() //Allows you to give this town NPC a chat message when a player talks to it.
{
int wizardNPC = NPC.FindFirstNPC(NPCID.Wizard); //this make so when this npc is close to Wizard
if (wizardNPC >= 0 && Main.rand.Next(4) == 0) //has 1 in 3 chance to show this message
{
return "Yes " + Main.npc[wizardNPC].displayName + " is a wizard.";
}
int guideNPC = NPC.FindFirstNPC(NPCID.Guide); //this make so when this npc is close to the Guide
if (guideNPC >= 0 && Main.rand.Next(4) == 0) //has 1 in 3 chance to show this message
{
return "Sure you can ask " + Main.npc[guideNPC].displayName + " how to make Ironskin potion or you can buy it from me..hehehe.";
}
switch (Main.rand.Next(4)) //this are the messages when you talk to the npc
{
case 0:
return "Doge does not die";
case 1:
return "Got that wall thing yet?";
case 2:
return "I like living here, it's very wow";
case 3:
return "Want to buy something?";
default:
return "Very wow";

}
}
public override void TownNPCAttackStrength(ref int damage, ref float knockback)// Allows you to determine the damage and knockback of this town NPC attack
{
damage = 40; //npc damage
knockback = 2f; //npc knockback
}

public override void TownNPCAttackCooldown(ref int cooldown, ref int randExtraCooldown) //Allows you to determine the cooldown between each of this town NPC's attack. The cooldown will be a number greater than or equal to the first parameter, and less then the sum of the two parameters.
{
cooldown = 5;
randExtraCooldown = 10;
}
//------------------------------------This is an example of how to make the npc use a sward attack-------------------------------
public override void DrawTownAttackSwing(ref Texture2D item, ref int itemSize, ref float scale, ref Vector2 offset)//Allows you to customize how this town NPC's weapon is drawn when this NPC is swinging it (this NPC must have an attack type of 3). Item is the Texture2D instance of the item to be drawn (use Main.itemTexture[id of item]), itemSize is the width and height of the item's hitbox
{
scale = 1f;
item = Main.itemTexture[mod.ItemType("Doge")]; //this defines the item that this npc will use
itemSize = 56;
}

public override void TownNPCAttackSwing(ref int itemWidth, ref int itemHeight) // Allows you to determine the width and height of the item this town NPC swings when it attacks, which controls the range of this NPC's swung weapon.
{
itemWidth = 56;
itemHeight = 56;
}


}
 
using System;
using System.Collections.Generic;
using Microsoft.Xna.Framework;
using Microsoft.Xna.Framework.Graphics;
using Terraria.ID;
using Terraria;
using Terraria.ModLoader;

namespace DogeMod.NPCs
{
[AutoloadHead]
public class gooddoge : ModNPC
{

public override bool Autoload(ref string name)
{
name = "gooddoge";
return mod.Properties.Autoload;
}

public override void SetDefaults()
{
npc.name = "The Good Doge"; //the name displayed when hovering over the npc ingame.
npc.townNPC = true; //This defines if the npc is a town Npc or not
npc.friendly = true; //this defines if the npc can hurt you or not()
npc.width = 18; //the npc sprite width
npc.height = 46; //the npc sprite height
npc.aiStyle = 7; //this is the npc ai style, 7 is Pasive Ai
npc.defense = 25; //the npc defense
npc.lifeMax = 250;// the npc life
npc.HitSound = SoundID.NPCHit1; //the npc sound when is hit
npc.DeathSound = SoundID.NPCDeath1; //the npc sound when he dies
npc.knockBackResist = 0.5f; //the npc knockback resistance
Main.npcFrameCount[npc.type] = 25; //this defines how many frames the npc sprite sheet has
NPCID.Sets.ExtraFramesCount[npc.type] = 9;
NPCID.Sets.AttackFrameCount[npc.type] = 4;
NPCID.Sets.DangerDetectRange[npc.type] = 150; //this defines the npc danger detect range
NPCID.Sets.AttackType[npc.type] = 3; //this is the attack type, 0 (throwing), 1 (shooting), or 2 (magic). 3 (melee)
NPCID.Sets.AttackTime[npc.type] = 30; //this defines the npc attack speed
NPCID.Sets.AttackAverageChance[npc.type] = 10;//this defines the npc atack chance
NPCID.Sets.HatOffsetY[npc.type] = 4; //this defines the party hat position
animationType = NPCID.Guide; //this copy the guide animation
}
public override bool CanTownNPCSpawn(int numTownNPCs, int money) //Whether or not the conditions have been met for this town NPC to be able to move into town.
{
if (NPC.downedBoss113) //so after the Wall is killed
{
return true;
}
return false;
}
public override bool CheckConditions(int left, int right, int top, int bottom) //Allows you to define special conditions required for this town NPC's house
{
return true; //so when a house is available the npc will spawn
}
public override string TownNPCName() //Allows you to give this town NPC any name when it spawns
{
switch (WorldGen.genRand.Next(6))
{
case 0:
return "Wyatt";
case 1:
return "Jack";
case 2:
return "Michael";
case 3:
return "Shiba";
case 4:
return "Green Doge";
case 5:
return "Blue Wow";
default:
return "Mr. Inu";
}
}

public override void SetChatButtons(ref string button, ref string button2) //Allows you to set the text for the buttons that appear on this town NPC's chat window.
{
button = "Shop"; //this defines the buy button name
}
public override void OnChatButtonClicked(bool firstButton, ref bool openShop) //Allows you to make something happen whenever a button is clicked on this town NPC's chat window. The firstButton parameter tells whether the first button or second button (button and button2 from SetChatButtons) was clicked. Set the shop parameter to true to open this NPC's shop.
{

if (firstButton)
{
openShop = true; //so when you click on buy button opens the shop
}
}

public override void SetupShop(Chest shop, ref int nextSlot) //Allows you to add items to this town NPC's shop. Add an item by setting the defaults of shop.item[nextSlot] then incrementing nextSlot.
{
if (NPC.downedSlimeKing) //this make so when the king slime is killed the town npc will sell this
{
shop.item[nextSlot].SetDefaults(ItemID.ThornHook); //an example of how to add a vanilla terraria item
nextSlot++;
shop.item[nextSlot].SetDefaults(ItemID.WormholePotion);
nextSlot++;
shop.item[nextSlot].SetDefaults(ItemID.ImpStaff);
nextSlot++;
}
if (NPC.downedBoss127) //this make so when SkeletronPrime is killed the town npc will sell this
{
shop.item[nextSlot].SetDefaults(ItemID.SolarCultistHood);
nextSlot++;
shop.item[nextSlot].SetDefaults(ItemID.SolarCultistRobe);
nextSlot++;
}
shop.item[nextSlot].SetDefaults(ItemID.IronskinPotion);
nextSlot++;
shop.item[nextSlot].SetDefaults(mod.ItemType("Doge")); //this is an example of how to add a modded item
nextSlot++;

}

public override string GetChat() //Allows you to give this town NPC a chat message when a player talks to it.
{
int wizardNPC = NPC.FindFirstNPC(NPCID.Wizard); //this make so when this npc is close to Wizard
if (wizardNPC >= 0 && Main.rand.Next(4) == 0) //has 1 in 3 chance to show this message
{
return "Yes " + Main.npc[wizardNPC].displayName + " is a wizard.";
}
int guideNPC = NPC.FindFirstNPC(NPCID.Guide); //this make so when this npc is close to the Guide
if (guideNPC >= 0 && Main.rand.Next(4) == 0) //has 1 in 3 chance to show this message
{
return "Sure you can ask " + Main.npc[guideNPC].displayName + " how to make Ironskin potion or you can buy it from me..hehehe.";
}
switch (Main.rand.Next(4)) //this are the messages when you talk to the npc
{
case 0:
return "Doge does not die";
case 1:
return "Got that wall thing yet?";
case 2:
return "I like living here, it's very wow";
case 3:
return "Want to buy something?";
default:
return "Very wow";

}
}
public override void TownNPCAttackStrength(ref int damage, ref float knockback)// Allows you to determine the damage and knockback of this town NPC attack
{
damage = 40; //npc damage
knockback = 2f; //npc knockback
}

public override void TownNPCAttackCooldown(ref int cooldown, ref int randExtraCooldown) //Allows you to determine the cooldown between each of this town NPC's attack. The cooldown will be a number greater than or equal to the first parameter, and less then the sum of the two parameters.
{
cooldown = 5;
randExtraCooldown = 10;
}
//------------------------------------This is an example of how to make the npc use a sward attack-------------------------------
public override void DrawTownAttackSwing(ref Texture2D item, ref int itemSize, ref float scale, ref Vector2 offset)//Allows you to customize how this town NPC's weapon is drawn when this NPC is swinging it (this NPC must have an attack type of 3). Item is the Texture2D instance of the item to be drawn (use Main.itemTexture[id of item]), itemSize is the width and height of the item's hitbox
{
scale = 1f;
item = Main.itemTexture[mod.ItemType("Doge")]; //this defines the item that this npc will use
itemSize = 56;
}

public override void TownNPCAttackSwing(ref int itemWidth, ref int itemHeight) // Allows you to determine the width and height of the item this town NPC swings when it attacks, which controls the range of this NPC's swung weapon.
{
itemWidth = 56;
itemHeight = 56;
}


}

Try that
 
I think it's asking for the sprite...
Put this above the AutoLoad line I gave you.
public override string Texture
{
get
{
return "ModName/NPCs/NPCName";
}
}
 
Ok, we are so close I think. But T-modloader says this line is wrong. Maybe it's something very small?

public override bool Autoload(ref string name, ref string texture, ref string altTextures)

By the way, we should be joint terraria mod devs.
 
Ok, we are so close I think. But T-modloader says this line is wrong. Maybe it's something very small?

public override bool Autoload(ref string name, ref string texture, ref string altTextures)

By the way, we should be joint terraria mod devs.

Hm, I don't know what the problem is honestly.
 
Back
Top Bottom