All the summon weapons introduced in 1.4 and 1.4.1, with the apparent exception of the Vampire Frog staff, use the Deadly Sphere Staff use sound effect, which is very metallic and digital-sounding. It doesn't suit many of the new summon weapons well at all, as it was intended to be the unique sound of the Deadly Sphere Staff when it was introduced. It seems almost as if the sound effect just got copied when the new items were created, and what sound effect would best suit each summon weapon never came under consideration.
Summoner Weapon Sounds
Item_44 – A diminutive croak. The default summoner weapon sound.
Item_76 – A fluttering whoosh. The unique sound of the Hornet Staff.
Item_77 – A hollow whoosh. The unique sound of the Imp Staff.
Item_82 – A mechanical whoosh. The unique sound of the Optic Staff.
Item_83 – A chittering whoosh. The unique sound of the Spider Staff.
Item_113 – A robotic/arcane whoosh. The unique sound of the Deadly Sphere Staff before it was added to most 1.4 summons. Now used for seven staves, six of which are new.
Meanwhile, large numbers of summon weapons introduced in previous updates still use the Item_44 sound effect, including both Stardust staves. The sound is extremely basic, and ill-suited to the endgame summon staves.
Below are my suggestions for what I think should be changed, along with my reasoning:
Pre-Hardmode Summon Weapons
Finch Staff — Item_113
-> Item_44 (Item_44 is the best fit here, as it sounds like a small animal.)
Flinx Staff — Item_113
-> Item_44
Slime Staff — Item_44
Hornet Staff — Item_76
Vampire Frog Staff — Item_44
Imp Staff — Item_77
Hardmode Summon Weapons
Spider Staff — Item_83
Blade Staff — Item_113
-> Item_77 (The Imp Staff's sound is the most neutral of the sounds, and I think it suits an arcane dagger.)
Sanguine Staff — Item_113
-> Item_83 (The chittering Spider Staff sound is well-suited to a bat minion.)
Optic Staff — Item_82
Pirate Staff — Item_44
Pygmy Staff — Item_44
Raven Staff — Item_44
Desert Tiger Staff — Item_113
-> Item_77 (The Desert Tiger sound should be more majestic than Item_44, but not robotic like it is now. Once again, the Imp Staff's sound is the best fit.)
Tempest Staff — Item_44
-> Item_77 (The Imp Staff's whoosh is a better fit for an arcane shark-hurling whirlpool than the unassuming Item_44.)
Deadly Sphere Staff — Item_113
Xeno Staff — Item_44
-> Item_82 (The Optic Staff sound fits the flavour of a Martian Saucer better than Item_44.)
Stardust Cell Staff — Item_44
-> Item_113 (Item_113 sounds both technological and arcane, giving the Stardust staves the dramatic sound they deserve.)
Stardust Dragon Staff — Item_44
-> Item_113 (See above.)
Terraprisma — Item_113 (This one can be left as is, as the Deadly Sphere Staff sound already suits it well.)
Hardmode Sentry Staves (Tavernkeep sentries not included, as they have their own set of consistent sound effects.)
Queen Spider Staff —
Item_78 +
Item_46
Staff of the Frost Hydra —
Item_1 + Item_46
Rainbow Crystal Staff — Item_78
-> [Item_1 + Item_46] (Change to same pair of sounds as Staff of the Frost Hydra.)
Lunar Portal Staff — Item_78
-> [Item_1 + Item_46] (Change to same pair of sounds as Staff of the Frost Hydra.)
(The Queen Spider Staff and Staff of the Frost Hydra have both a "Use" sound effect and "Summon" sound effect. The Moon Lord staves only have a "Use" sound effect.)
For some reason, the Rainbow Crystal Staff and Lunar Portal Staff use the same sound effect as the Queen Spider Staff, which is very chittery and spider-like. It sounds too specific, as it was obviously created for the Queen Spider Staff alone. It'd be better if the two Moon Lord staves used the same non-specific sounds as the Staff of the Frost Hydra. (Possibly, even Item_113 + Item_46 could be used for the Moon Lord staves.)