As someone who uses Luck Potions in Terraria Avalon a lot, I can say that having them in vanilla would be amazing.
I see there has been some skepticism on the idea, so let me say some things from my own experiences while using Avalon's equivalent:
- Doubling the drop rate on some thing actually isn't as big of a deal as you might think. In a lot of cases the drop rates are still stupidly low.
- Even with the half an hour duration it has in Exxo Avalon, depending on what you're trying to get you're likely to still need multiple potions to get what you want.
- In the end the Luck Potion merely makes grinding for some items less painful, at the cost of hitting your herb stores kinda hard. (To be honest, the recipes he's proposing is even harder than the one in Exxo Avalon, which I think is pretty fair.)
- This one lasts 5 minutes. To be honest, that's not actually very good, all things considered, so it hits your resources even harder because in a lot of cases you're going to need multiples.
- Let's take an example from one of the most notoriously rare items in the entire game, the Key Molds. They have a 1 in 2500 chance to drop. With the Luck Potion, that becomes 1 in 1250. Those numbers are .04% and .08%, respectively. A really low chance that's doubled is still a really low chance. In this case it'd save you maybe 1250 kills, if you're lucky; if you're unlucky, you might've been slated to get the mold on your next kill regardless of whether or not you actually use the potion. (By contrast, any item with a 50% or more drop rate instantly drops 100% of the time. No, examples like my Essence Shards would NOT result in a 180% drop rate, sorry; it'd cap out at 100%. Now, a potion to double the drop quantity of variable quantity drops...)
In the end the potion lessens the RNG abuse, but does not fix it by any means. Drinking the Luck Potion will not instantly get you drops out the
- that's not how it works.